Inject SQL Server Application Name in a more robust way#37428
Merged
roji merged 2 commits intodotnet:mainfrom Dec 30, 2025
Merged
Inject SQL Server Application Name in a more robust way#37428roji merged 2 commits intodotnet:mainfrom
roji merged 2 commits intodotnet:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of SQL Server application name injection by replacing FileVersionInfo.GetVersionInfo(Assembly.GetExecutingAssembly().Location).ProductVersion with Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion. This change enhances NativeAOT compatibility by avoiding reliance on Assembly.Location, which can be empty or unavailable in single-file deployments and NativeAOT scenarios.
Key changes:
- Replaced file system-based version retrieval with reflection attribute-based approach
- Aligns with patterns used elsewhere in the codebase (ProductInfo.cs, DatabaseProvider.cs)
- Maintains backward compatibility while improving deployment scenario support
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AndriySvyryd
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37115
Thanks to @0xced for proposing this in #36548 (comment).
Verified via test ApplicationName_is_injected_when_not_defined_with_connection_string that the injected Application Name is the same before and after this change.