Fix up and reenable analyzer tests #37427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @Youssef1313, thanks for the tip in #37106 (comment). |
There was a problem hiding this comment.
Pull request overview
This PR migrates the analyzer tests from obsolete XUnit-specific testing packages to the newer non-obsolete packages recommended by the Roslyn SDK team. The changes update package references, refactor test infrastructure to use the new API patterns, and re-enable previously disabled analyzer tests.
Key changes:
- Upgrades Microsoft.CodeAnalysis testing packages to version 1.1.3-beta1.25564.1 and switches from XUnit-specific to non-XUnit packages
- Refactors test utility classes to use constructors instead of overriding CreateProjectImplAsync, and changes from XUnitVerifier to DefaultVerifier
- Adds RootFinder utility class to locate the repository root for NuGet.config resolution
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/Versions.props | Updates test dependency versions to 1.1.3-beta1.25564.1 with reference to issue #1175 |
| test/Directory.Packages.props | Switches from Microsoft.CodeAnalysis.*.Testing.XUnit packages to non-XUnit variants |
| test/EFCore.Analyzers.Tests/EFCore.Analyzers.Tests.csproj | Updates package references to remove .XUnit suffix |
| test/EFCore.Analyzers.Tests/TestUtilities/CSharpAnalyzerVerifier.cs | Refactors to use DefaultVerifier and constructor-based setup with DisabledDiagnostics |
| test/EFCore.Analyzers.Tests/TestUtilities/CSharpCodeFixVerifier.cs | Refactors to use DefaultVerifier and constructor-based setup with DisabledDiagnostics |
| test/EFCore.Analyzers.Tests/TestUtilities/RootFinder.cs | Adds utility class to locate Git repository root for NuGet.config path resolution |
| test/EFCore.Analyzers.Tests/UninitializedDbSetDiagnosticSuppressorTests.cs | Changes test class visibility from internal to public and removes issue comment |
| test/EFCore.Analyzers.Tests/StringInterpolationInRawQueriesAnalyzerTests.cs | Changes test class visibility from internal to public and removes issue comment |
| test/EFCore.Analyzers.Tests/StringConcatenationInRawQueriesAnalyzerTests.cs | Changes test class visibility from internal to public and removes issue comment |
| test/EFCore.Analyzers.Tests/InternalUsageDiagnosticAnalyzerTests.cs | Changes test class visibility from internal to public and removes issue comment |
AndriySvyryd
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/dotnet/roslyn-sdk/tree/main/src/Microsoft.CodeAnalysis.Testing#obsolete-packages
Closes #35768
Closes #37106