[release/10.0] Fix Cosmos parameter naming for FromSql and regular parameters #37273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84d57d8 to
71244b1
Compare
71244b1 to
306b55e
Compare
cincuranet
approved these changes
Dec 2, 2025
SamMonoRT
approved these changes
Dec 2, 2025
artl93
approved these changes
Dec 2, 2025
Member
artl93
left a comment
There was a problem hiding this comment.
Customer reported regression w/ quirk. Approved.
Member
|
@roji - FYI should this be targeting main, or release? |
Member
Author
|
Good catch @artl93, thanks - will rebase. |
Member
Author
|
Approved via email. |
This was referenced Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37252
Description
EF 10 brought multiple improvements in how parameters are named and managed. Unfortunately, an edge case in the Cosmos provider specifically wasn't dealt with, leading to a regression.
Customer impact
Cosmos queries use the FromSql() API (raw SQL, non-LINQ querying), and also call Skip or Take (LINQ operators which accept a parameter directly, without a lambda) generate incorrect SQL that will fail, or in some edge cases, might return incorrect data.
How found
Customer reported on 10.0.0
Regression
Yes.
Testing
Added.
Risk
Low: short, targeted fix. Quirk added.