[release/10.0] Fix snapshot generation for complex collection properties #37271
+145
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@copilot Add a ModelDiffer test to check that no operations are generated when the model contains an annotation that's ignored in the snapshot |
Skip generating HasMaxLength and HasPrecision annotations for properties in complex collections since ComplexCollectionTypePropertyBuilder doesn't support these methods. Also skip IsConcurrencyToken and ValueGenerated* methods for the same reason. Fixes #37256 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix snapshot generation to ignore irrelevant annotations
Fix snapshot generation for complex collection properties
Dec 1, 2025
Add test to verify that no operations are generated when the model contains annotations (like MaxLength) that are ignored in the snapshot for complex collection properties. Addresses review feedback from @AndriySvyryd Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Contributor
Author
Added |
AndriySvyryd
reviewed
Dec 2, 2025
test/EFCore.Design.Tests/Migrations/Design/CSharpMigrationsGeneratorTest.ModelSnapshot.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Relational.Tests/Migrations/Internal/MigrationsModelDifferTest.cs
Show resolved
Hide resolved
- Remove method overloads with isInComplexCollection parameter - Check property.DeclaringType directly to determine if in complex collection - Update test to also configure IsConcurrencyToken, ValueGenerated, precision and scale - Empty target lambda in ModelDiffer test as snapshot doesn't have extra config Addresses review feedback from @AndriySvyryd Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Member
|
@copilot Update progress by rewriting the PR summary using this template: |
Contributor
Author
... Updated the PR description with the requested template format. |
roji
approved these changes
Dec 2, 2025
SamMonoRT
approved these changes
Dec 8, 2025
Member
|
cc @artl93 |
artl93
approved these changes
Dec 8, 2025
Member
artl93
left a comment
There was a problem hiding this comment.
Customer reported. New area. Limited scope with targeted fix. Approved.
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37256
Description
Snapshot generation for properties in complex collections produces uncompilable code because it emits fluent API calls (
HasMaxLength,HasPrecision,IsConcurrencyToken,ValueGenerated*) that don't exist onComplexCollectionTypePropertyBuilder.Customer impact
Customers using bulk configuration of these facets for all properties get compilation errors in their generated migration snapshot files. The workaround is to manually remove the unsupported fluent API calls from the generated snapshot.
How found
Customer reported on EF 10. This is expected to affect a small part of developers using complex collections.
Regression
No. It only manifests when a new EF 10 feature is used.
Testing
Tests added.
Risk
Low. The targeted fix is to just avoid emitting invalid code for the affected scenarios.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.