Fix shaper support for JSON collections #36575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Aug 14, 2025
| NullSafeAssert<RelatedType>(e.RequiredRelated, a.RequiredRelated, AssertRelatedType); | ||
| NullSafeAssert<RelatedType>(e.OptionalRelated, a.OptionalRelated, AssertRelatedType); | ||
|
|
||
| // TODO: Complete for collection, mind ordering (how is this done elsewhere?) |
16 tasks
872fe59 to
86d811b
Compare
AndriySvyryd
approved these changes
Aug 14, 2025
Member
|
Search for #31376 in the solution and uncomment the other tests |
Member
Author
Some of these seem to fail because there are value types in there - let's revisit in a few days. |
Also fix and improve relationship tests. Part of dotnet#36296
7ca31e6 to
c5d6a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix and improve relationship tests.
Part of #36296