Named query filters#36028

Merged

cincuranet merged 18 commits into

dotnet:mainfrom

bittola:bittola/named_query_filters

Jun 9, 2025

bittola commented May 2, 2025 •

edited by cincuranet

Loading

Contributor

I've read the guidelines for contributing and seen the walkthrough
I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
The code builds and tests pass locally (also verified by our automated build checks)
Tests for the changes have been added (for bug fixes / features)
Code follows the same patterns and style as existing code in this repo

Closes: #8576
Closes: #10275

bittola added 5 commits

November 13, 2024 23:23


          Adding support for multiple and named query filters

2e57029


          Merge branch 'main' into bittola/named_query_filters

5e0ccca


          fixed test

d955bc8


          Addressing comments from API review

f1a0046


          Merge branch 'main' into bittola/named_query_filters

9eb38bb

bittola requested a review from a team as a code owner

May 2, 2025 02:58

bittola marked this pull request as draft

May 2, 2025 04:47


          Fixing caching of the query filters

cbc7fed

bittola marked this pull request as ready for review

May 2, 2025 06:10

bittola changed the title ~~Bittola/named query filters~~ Named query filters


          updating a hashset containing ignored filters to be of type of string

ced4074

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Internal/InternalEntityTypeBuilder.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/IReadOnlyEntityType.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/IConventionEntityType.cs Outdated

AndriySvyryd reviewed

View reviewed changes

test/EFCore.Tests/ApiConsistencyTest.cs Outdated

AndriySvyryd commented May 2, 2025

Member

Also add tests in InternalEntityTypeBuilderTest to verify that named filters set using ConfigurationSource.Convention can be removed or overridden by ConfigurationSource.Explicit or ConfigurationSource.DataAnnotation, but not the other way around.

AndriySvyryd assigned maumar

Ladislav Bitto added 2 commits

May 7, 2025 19:46


          addressing comments

59a1128


          updates

c09e7f5

maumar reviewed

View reviewed changes

src/EFCore/Query/QueryCompilationContext.cs Outdated


          addressing comments

d37de90

maumar reviewed

View reviewed changes

src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/IConventionEntityType.cs Outdated

Ladislav Bitto added 2 commits

May 15, 2025 13:00


          Merge branch 'main' into bittola/named_query_filters

58fd77d


          addressing comments

4be1c88

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Conventions/QueryFilterRewritingConvention.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore.Relational/Metadata/Conventions/RelationalQueryFilterRewritingConvention.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Internal/RuntimeQueryFilter.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Internal/RuntimeQueryFilter.cs Outdated


          addressing comments

1dc6b39

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Internal/QueryFilter.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/IQueryFilter.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/IReadOnlyEntityType.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Internal/EntityType.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Internal/QueryFilterCollection.cs Outdated


          addressing comments

0988e1c

AndriySvyryd assigned AndriySvyryd and unassigned maumar

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/IReadOnlyEntityType.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/RuntimeEntityType.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Internal/EntityType.cs Outdated

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs Outdated


          addressing comments

707d734

AndriySvyryd reviewed

View reviewed changes

src/EFCore/Metadata/Internal/RuntimeQueryFilterCollection.cs Outdated

AndriySvyryd requested a review from cincuranet

May 21, 2025 00:22


          addressing comments

3f9934f

AndriySvyryd approved these changes

View reviewed changes

cincuranet requested changes

View reviewed changes

src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs Outdated

src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs

src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs Outdated

src/EFCore/Query/Internal/QueryFiltersCacheKey.cs Outdated

src/EFCore/Query/Internal/NavigationExpandingExpressionVisitor.cs Outdated

test/EFCore.Specification.Tests/Query/AdHocQueryFiltersQueryTestBase.cs Outdated

test/EFCore.Specification.Tests/Query/AdHocQueryFiltersQueryTestBase.cs Outdated

test/EFCore.Specification.Tests/Query/AdHocQueryFiltersQueryTestBase.cs Outdated

test/EFCore.Specification.Tests/Query/AdHocQueryFiltersQueryTestBase.cs Outdated

test/EFCore.Specification.Tests/Query/AdHocQueryFiltersQueryTestBase.cs Outdated

cincuranet self-assigned this

Ladislav Bitto added 2 commits

June 4, 2025 08:56


          addressing comments

2becb6d


          updates

67b81ba

cincuranet approved these changes

View reviewed changes

cincuranet merged commit ab1b36e into dotnet:main

7 checks passed

cincuranet commented Jun 9, 2025

Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet