Skip to content

Conversation

@roji
Copy link
Member

@roji roji commented Nov 14, 2024

Closes #35089

@roji roji requested a review from a team November 14, 2024 00:06
@roji roji force-pushed the QueryParameters branch 2 times, most recently from 9175213 to 3d9c8c4 Compare November 14, 2024 09:52
@roji roji marked this pull request as ready for review November 14, 2024 10:49
{
Name = name;
Type = type;
ShouldBeConstantized = shouldBeConstantized;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record I am not in love with these names

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to me. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll pick this up again in API design ;)

{
Name = name;
Type = type;
ShouldBeConstantized = shouldBeConstantized;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to me. :)

@roji roji merged commit cda7816 into dotnet:main Nov 19, 2024
@roji roji deleted the QueryParameters branch November 19, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Represent query parameters with a dedicated type instead of ParameterExpression

2 participants