Skip to content

Remove migration lock timeout#34338

Merged
AndriySvyryd merged 1 commit intomainfrom
Issue17578_followup
Aug 14, 2024
Merged

Remove migration lock timeout#34338
AndriySvyryd merged 1 commit intomainfrom
Issue17578_followup

Conversation

@AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Aug 2, 2024

Log migration lock acquisition
Move seeding to options

Fixes #34196
Fixes #17578

@AndriySvyryd AndriySvyryd requested a review from a team August 2, 2024 03:03
@roji
Copy link
Member

roji commented Aug 3, 2024

See comment on possibly continuing to have cancellation and timeout, but fully client-managed: #34196 (comment)

@AndriySvyryd AndriySvyryd force-pushed the Issue17578_followup branch 2 times, most recently from 922be3c to f8ca271 Compare August 10, 2024 05:31
@AndriySvyryd
Copy link
Member Author

Follow-up from the API review: using UseSeeding on the generic DbContextOptionsBuilder<> doesn't produce ambiguity. Action<DbContext, bool> is chosen by default and Action<TContext, bool> is chosen if the lambda has code referencing anything a member on TContext that's not on DbContext.

TLDR: it just works!

@AndriySvyryd
Copy link
Member Author

/azp run

@AndriySvyryd AndriySvyryd reopened this Aug 12, 2024
@AndriySvyryd AndriySvyryd force-pushed the Issue17578_followup branch 2 times, most recently from faf7b1c to 5bcf44f Compare August 12, 2024 23:55
Log migration lock acquisition

Fixes #34196
Fixes #17578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Migrate lock timeout Execution strategy for migration

2 participants