Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
d018d29 to
84ebd38
Compare
roji
reviewed
Jul 12, 2024
c2dd124 to
69bcb92
Compare
roji
approved these changes
Jul 27, 2024
Member
roji
left a comment
There was a problem hiding this comment.
This was accidentally merged by me as part of #34206... @AndriySvyryd let's review possible fix-up when you're back.
But it looks good to me as-is (with a possible comment or two), approving post-hoc.
69bcb92 to
b6fbc55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to specify a target migration in Migrate call
Warn on Migrate when there are pending model changes
Fixes #17568
Fixes #33732
Fixes #34196