Skip to content

[release/8.0] Don't discover DbFunctions when building ad-hoc model#32807

Merged
ajcvickers merged 2 commits intorelease/8.0from
240113_Specs2
Jan 16, 2024
Merged

[release/8.0] Don't discover DbFunctions when building ad-hoc model#32807
ajcvickers merged 2 commits intorelease/8.0from
240113_Specs2

Conversation

@ajcvickers
Copy link
Copy Markdown
Contributor

@ajcvickers ajcvickers commented Jan 13, 2024

Fixes #32680
Port of #32790

Description

Raw SQL queries for unmapped types will fail if a DbFunction is registered on the DbContext and the referenced entity type does not map by convention.

Customer impact

Raw SQL queries will throw in this scenario.

How found

Customer reported on 8.

Regression

No. Raw SQL queries for unmapped types is a new feature in 8.0.

Testing

Tests added.

Risk

Low. Quirked.

Fixes #32680

Two follow on items after this is merged:
- Port to 8
- Make AdHocMapper public
@ajcvickers ajcvickers requested a review from a team January 13, 2024 11:04
@ajcvickers ajcvickers added this to the 8.0.x milestone Jan 13, 2024
@ErikEJ
Copy link
Copy Markdown
Contributor

ErikEJ commented Jan 13, 2024

Planned for 8.0.3?

@ajcvickers
Copy link
Copy Markdown
Contributor Author

@ErikEJ Depends when it gets approved.

@ajcvickers ajcvickers modified the milestones: 8.0.x, 8.0.2 Jan 16, 2024
@ajcvickers ajcvickers merged commit 86dd535 into release/8.0 Jan 16, 2024
@ajcvickers ajcvickers deleted the 240113_Specs2 branch January 16, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants