[release/8.0] Create correct JSON reader/writer for double nested value conversions#32448
Merged
wtgodbe merged 2 commits intorelease/8.0from Jan 3, 2024
Merged
[release/8.0] Create correct JSON reader/writer for double nested value conversions#32448wtgodbe merged 2 commits intorelease/8.0from
wtgodbe merged 2 commits intorelease/8.0from
Conversation
AndriySvyryd
approved these changes
Nov 29, 2023
Member
|
Note that the branch is currently closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #32444
Fixes #32376
Description
When a custom converter is applied over an existing built-in converter, then the wrong JSON reader/writer can be used.
Customer impact
Exception thrown when translating a previously working Contains query.
How found
Customer reported on 8.0
Regression
Yes
Testing
Added.
Risk
Very low; quirk added.