Allow service properties typed as object#29919
Merged
ajcvickers merged 2 commits intomainfrom Dec 23, 2022
Merged
Conversation
AndriySvyryd
approved these changes
Dec 23, 2022
Member
AndriySvyryd
left a comment
There was a problem hiding this comment.
Also need to add support to CSharpRuntimeModelCodeGenerator and a test to CSharpRuntimeModelCodeGeneratorTest
Fixes #10042 Service properties have two uses: 1. Allow the entity to use the service directly 2. Allow EF to store state on the entity This change allows 2 to happen without the entity needing to take a dependency on the service type. This allows the lazy-loader to store loaded state in the entity.
2740b2c to
7e8b889
Compare
|
I can't seem to get this working with ILazyLoader, looks like it's trapping because there's a shadow property and it's detached |
Contributor
Author
|
@ashortland-eqix Please open a new issue and attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10042
Service properties have two uses:
This change allows 2 to happen without the entity needing to take a dependency on the service type. This allows the lazy-loader to store loaded state in the entity.