Merged
Conversation
roji
approved these changes
Apr 28, 2022
Member
roji
left a comment
There was a problem hiding this comment.
🐑 🇮🇹
If anyone else is more proficient in this area it would be good to get another review, otherwise here are some nits :)
src/EFCore.Relational/Update/Internal/ColumnAccessorsFactory.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Migrations/Internal/MigrationsModelDiffer.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Relational.Tests/Update/ReaderModificationCommandBatchTest.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Relational.Tests/Migrations/Internal/MigrationsModelDifferTest.cs
Show resolved
Hide resolved
AndriySvyryd
commented
Apr 28, 2022
Comment on lines
+49
to
+53
| var providerType = Converter?.ProviderClrType ?? ClrType; | ||
| if (providerType.IsAssignableTo(typeof(TGeometry))) | ||
| { | ||
| ProviderValueComparer = (ValueComparer)Activator.CreateInstance(typeof(GeometryValueComparer<>).MakeGenericType(providerType))!; | ||
| } |
Fix typos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use row-based diffing for data seeding
Part of #3170
Fixes #22063
Fixes #12466
Fixes #27575