Don't detect public service properties in hierarchy as duplicates#24462
Merged
ajcvickers merged 3 commits intomainfrom Mar 25, 2021
Merged
Don't detect public service properties in hierarchy as duplicates#24462ajcvickers merged 3 commits intomainfrom
ajcvickers merged 3 commits intomainfrom
Conversation
Contributor
Author
|
Updated this to support multiple service properties of the same type, rather than block them, since supporting them is less code/complexity than blocking them. |
AndriySvyryd
approved these changes
Mar 23, 2021
Fixes #23968 Service properties are most commonly private. We were missing test coverage for public service properties in a type hierarchy, which was hiding this bug where we detect the property reflected from the base type as a duplicate. Fix is to match duplicates by name.
5d14c13 to
fcb0580
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23968
Service properties are most commonly private. We were missing test coverage for public service properties in a type hierarchy, which was hiding this bug where we detect the property reflected from the base type as a duplicate. Fix is to match duplicates by name.