Split Microsoft.EntityFrameworkCore.Analyzers into language-specific analyzers#22195
Split Microsoft.EntityFrameworkCore.Analyzers into language-specific analyzers#22195sharwell wants to merge 1 commit intodotnet:release/5.0from
Conversation
| <RootNamespace>Microsoft.EntityFrameworkCore</RootNamespace> | ||
|
|
||
| <IncludeBuildOutput>false</IncludeBuildOutput> | ||
| <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> |
There was a problem hiding this comment.
📝 This line eliminates the need for the _._ files.
|
Oh wow, thanks for submitting this! We'll have a chat in EF triage a bit later today about it. |
Youssef1313
left a comment
There was a problem hiding this comment.
nit: some markdown parsers require blank lines around tables.
Also, MD022 requires blank lines around headings.
| return syntax switch | ||
| { | ||
| _ => syntax, | ||
| }; |
There was a problem hiding this comment.
Why not return syntax directly?
There was a problem hiding this comment.
It seems likely that someone would want to alter this in the future to provide more specific results for VB.
|
Postponing merging this PR as per #22177 (comment) |
|
This can be rebased and merged to main now. |
|
Note: am going to defer working on this until we make a decision on what happens with pubternality... Even though we may still want to provide analyzers for other purposes, this is the only one we currently have. |
|
Is there plans to continue this soon? |
|
If this PR or something like it is needed still, please retarget release/6.0 |
Fixes #22177