Skip to content

Disallow setting custom translation for DbFunction mapped to TVFs#20315

Merged
smitpatel merged 1 commit intomasterfrom
smit/tvf
Mar 17, 2020
Merged

Disallow setting custom translation for DbFunction mapped to TVFs#20315
smitpatel merged 1 commit intomasterfrom
smit/tvf

Conversation

@smitpatel
Copy link
Contributor

Resolves #20163

@smitpatel smitpatel requested a review from AndriySvyryd March 17, 2020 14:50
@AndriySvyryd
Copy link
Member

Even if having a custom translation is less useful it's still valid in some scenarios. So instead of just throwing this should be a warning that defaults to throwing.

@AndriySvyryd
Copy link
Member

Or we can do that when we introduce a better API to set the translation.

@smitpatel
Copy link
Contributor Author

We don't use custom translation in query. (We cannot use it either till API is changed). So throwing is better than warning and then ignoring it.

@AndriySvyryd
Copy link
Member

Please avoid merging more than 2 PRs per 30 minutes to master

@smitpatel smitpatel merged commit 6f19f3d into master Mar 17, 2020
@smitpatel smitpatel deleted the smit/tvf branch March 17, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disallow IDbFunction.HasTranslation when mapping the function to a TVF

2 participants