Handle value generation when value conversion is being used#11479
Merged
ajcvickers merged 1 commit intorelease/2.1from Mar 30, 2018
Merged
Handle value generation when value conversion is being used#11479ajcvickers merged 1 commit intorelease/2.1from
ajcvickers merged 1 commit intorelease/2.1from
Conversation
Contributor
Author
|
/cc @divega FYI |
Contributor
|
@ajcvickers are there still further improvements (like the ones we discussed yesterday) that would make sense to track in an issue, or do you prefer to wait for feedback? |
Contributor
Author
|
@divega Probably worth having an issue to check for other "safe" generators we could add, but would rather wait until after 2.1 before we add any more anyway, so we could just wait for feedback instead. |
AndriySvyryd
approved these changes
Mar 30, 2018
Fixes #11010 Approach is: * Throw by default if a converter is associated with a property that will use value generation * However, a value generator to use can be specified: * On the property * On the type mapping * On a converter * A client-side generator is added to the Guid converters so that Guid key scenarios still work
e732e03 to
b7ffe45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11010
Approach is: