Skip to content

Consider simplifying SQL parameter names (@__city_0 -> @city) #35113

@roji

Description

@roji

All our SQL parameters have a __ prefix; this is the result of an internal detail: the prefix allowed us to distinguish between query parameter (captured variables) and lambda parameters; we're effectively leaking an internal implementation detail to our SQL shape. #35089 removes this need: the two parameter types (query, lambda) are now clearly distinguished via different node types. Since the prefix is no longer needed for EF's purposes, it can be removed, simplifying our parameter names.

We can also take this opportunity to make some other simplifications. For example, we append a running counter to parameter names in case the same name is used twice - an exceedingly rare situation. We can append the number only for that case, leading to most parameters being named more naturally (@city).

Metadata

Metadata

Assignees

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions