@jeffhandley I can't seem to make RequiresPreviewFeaturesAttribute work. I don't get any warnings or errors when using it. What am I missing here?

I'm using a local build of EF Core. My code checks that the attribute is present:

using System;
using System.Linq;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
using Microsoft.Extensions.Logging;

public class Foo
{
    public int Id { get; set; }
    public string? Bar { get; set; }
}

public class SomeDbContext : DbContext
{
    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder
            .UseInMemoryDatabase("Test")
            .LogTo(Console.WriteLine, LogLevel.Information)
            .EnableSensitiveDataLogging();

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        modelBuilder
            .Entity<Foo>()
            .Property(e => e.Bar)
            .HasConversion(new MyConverter());
    }
}

public class Program
{
    public static void Main()
    {
        var attributes = typeof(ValueConverter<,>)
            .GetConstructors()
            .Single(c => c.GetParameters().Any(p => p.Name == "convertsNulls"))
            .GetCustomAttributes(true)
            .ToList();

        foreach (var attribute in attributes)
        {
            Console.WriteLine($"Found: {attribute.GetType().Name}");
        }
        
        using (var context = new SomeDbContext())
        {
            context.Add(new Foo { Bar = "X" });
            context.SaveChanges();
        }
        
        using (var context = new SomeDbContext())
        {
            Console.WriteLine(context.Set<Foo>().Single().Bar);
        }
    }
}

public class MyConverter : ValueConverter<string?, string?>
{
    public MyConverter()
        : base(v => v, v => v, convertsNulls: true)
    {
    }
}

csproj:

<Project Sdk="Microsoft.NET.Sdk">

    <PropertyGroup>
        <OutputType>Exe</OutputType>
        <TargetFramework>net6.0</TargetFramework>
        <ImplicitUsings>enable</ImplicitUsings>
        <Nullable>enable</Nullable>
    </PropertyGroup>

    <ItemGroup>
      <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="6.0.0-dev" />
    </ItemGroup>

</Project>

Build correctly warns for using EF internal code, but nothing for the preview attribute:

PS C:\local\code\TestPreviewFeature> dotnet build
Microsoft (R) Build Engine version 17.0.0-preview-21458-01+2c5510013 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview
C:\local\code\TestPreviewFeature\Program.cs(61,9): warning EF1001: Microsoft.EntityFrameworkCore.Storage.ValueConversion.ValueConverter<string?, string?> is an internal API that supports the Entity Framework Core infrastructure and not subject to the same compatibility standards as public APIs. It may be changed or removed without notice in any release. [C:\local\code\TestPreviewFeature\TestPreviewFeature.csproj]
  TestPreviewFeature -> C:\local\code\TestPreviewFeature\bin\Debug\net6.0\TestPreviewFeature.dll

Build succeeded.

C:\local\code\TestPreviewFeature\Program.cs(61,9): warning EF1001: Microsoft.EntityFrameworkCore.Storage.ValueConversion.ValueConverter<string?, string?> is an internal API that supports the Entity Framework Core infrastructure and not subject to the same compatibility standards as public APIs. It may be changed or removed without notice in any release. [C:\local\code\TestPreviewFeature\TestPreviewFeature.csproj]
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:00:01.96

Running also results in no errors:

PS C:\local\code\TestPreviewFeature> dotnet run
Found: RequiresPreviewFeaturesAttribute
Found: EntityFrameworkInternalAttribute
warn: 10/6/2021 12:08:53.212 CoreEventId.SensitiveDataLoggingEnabledWarning[10400] (Microsoft.EntityFrameworkCore.Infrastructure)
      Sensitive data logging is enabled. Log entries and exception messages may include sensitive application data; this mode should only be enabled during development.
info: 10/6/2021 12:08:53.243 CoreEventId.ContextInitialized[10403] (Microsoft.EntityFrameworkCore.Infrastructure)
      Entity Framework Core 6.0.0-dev initialized 'SomeDbContext' using provider 'Microsoft.EntityFrameworkCore.InMemory:6.0.0-dev' with options: SensitiveDataLoggingEnabled StoreName=Test
info: 10/6/2021 12:08:53.307 InMemoryEventId.ChangesSaved[30100] (Microsoft.EntityFrameworkCore.Update)
      Saved 1 entities to in-memory store.
info: 10/6/2021 12:08:53.328 CoreEventId.ContextInitialized[10403] (Microsoft.EntityFrameworkCore.Infrastructure)
      Entity Framework Core 6.0.0-dev initialized 'SomeDbContext' using provider 'Microsoft.EntityFrameworkCore.InMemory:6.0.0-dev' with options: SensitiveDataLoggingEnabled StoreName=Test
X

EntityFrameworkExperimentalAttribute #26229

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions