Skip to content

Utility of DataReaderDisposing logging/interception #24295

@roji

Description

@roji

RelationalDataReader has a logging/interception hook for disposing - but not for closing the reader (which happens just before). there's very little difference between a closed and disposed reader - both states are almost the same since the reader cannot be reused (unlike connection for example). Also, any I/O would very likely occur during Close, which is where we don't log the elapsed time etc.

Do we know if/how users are using this? Should we make DataReaderDisposing include Close as well, so that users can skip that via interceptors, and so that its time is logged too?

/cc @ajcvickers

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions