This repository was archived by the owner on Mar 1, 2018. It is now read-only.
Update to utilize multi-step build feature#44
Merged
MichaelSimons merged 5 commits intodotnet:masterfrom Jun 29, 2017
Merged
Conversation
kendrahavens
approved these changes
Apr 24, 2017
Contributor
kendrahavens
left a comment
There was a problem hiding this comment.
Holding off sounds good. This really cleans up the process!
Contributor
|
I believe Docker merged the multi-stage build functionality into their stable channel today! Let's merge these samples. |
5671f27 to
437d87a
Compare
Member
Author
|
@kendrahavens - I updated the PR. I needed to merge in the multi-arch changes that came on-board since the original creation of the PR. I removed the |
Contributor
|
The WriteLine for the dotnetbot say samples should be changed to 1.1 instead of 1.0 with the upgrade. Everything else looks good. |
Member
Author
|
@kendrahavens - Good catch - I fixed dotnetbot to emit the correct version of .NET Core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the multi-step build infra is only available with Docker Edge release 17.05. We will want to hold off merging this until the multi-step infrastructure is released in Stable. I believe this will be 17.06.
fixes #50