Skip to content
This repository was archived by the owner on Feb 16, 2018. It is now read-only.

[WIP] Add Alpine SDK image#508

Closed
richlander wants to merge 4 commits intomasterfrom
alpine-sdk
Closed

[WIP] Add Alpine SDK image#508
richlander wants to merge 4 commits intomasterfrom
alpine-sdk

Conversation

@richlander
Copy link
Member

@richlander richlander commented Dec 23, 2017 •
edited by MichaelSimons
Loading

This PR isn't quite ready. Work items:

  • Update URL format (to match other images)
  • Add hash/checksum matching (to match other images)
  • Consider globalization invariant mode support for the SDK.
  • Update tests appropriately to verify Alpine SDK image
  • Update manifest.json
  • Update readme

Sample I used for testing: https://github.com/dotnet/dotnet-docker-samples/tree/alpine/dotnetapp-prod

I got the image to work as expected but needed to remove invariant-mode support for the SDK. it seems like the SDK fails to run with invariant mode.

This is the error that I saw before removing globalization invariant mode / adding ICU:

Step 7/11 : RUN dotnet publish -c Release -o out
 ---> Running in 0f3ff19e0e0f
Microsoft (R) Build Engine version 15.6.22.57775 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 46.27 ms for /app/dotnetapp.csproj.
/usr/share/dotnet/sdk/2.2.0-preview1-007846/Microsoft.Common.CurrentVersion.targets(2051,5): error MSB3095: Invalid argument. SafeHandle cannot be null. [/app/dotnetapp.csproj]
/usr/share/dotnet/sdk/2.2.0-preview1-007846/Microsoft.Common.CurrentVersion.targets(2051,5): error MSB3095: Parameter name: pHandle [/app/dotnetapp.csproj]
The command '/bin/sh -c dotnet publish -c Release -o out' returned a non-zero code: 1

@MichaelSimons MichaelSimons mentioned this pull request Feb 1, 2018
Closed
This was referenced Feb 15, 2018
Closed
Merged
@MichaelSimons
Copy link
Member

MichaelSimons commented Feb 15, 2018

This PR was moved to the nightly branch of the dotnet/dotnet-docker repo - dotnet/dotnet-docker#376

@richlander richlander mentioned this pull request Jan 31, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@richlander @MichaelSimons