Update samples for platform targeting#4441
Closed
richlander wants to merge 7 commits intodotnet:mainfrom
Closed
Conversation
Member
|
Is this going to be backported to 7.0? |
mthalman
reviewed
Feb 22, 2023
| ## Container sample: Run a simple application | ||
|
|
||
| Enter the following command to run a console app in a container with a pre-built [.NET Docker image](https://hub.docker.com/_/microsoft-dotnet-samples/): | ||
| The following example runs a [.NET console app container image](https://hub.docker.com/_/microsoft-dotnet-samples/): |
Member
There was a problem hiding this comment.
Nit.
Suggested change
| The following example runs a [.NET console app container image](https://hub.docker.com/_/microsoft-dotnet-samples/): | |
| The following example runs a [.NET console app container](https://hub.docker.com/_/microsoft-dotnet-samples/): |
| ## Container sample: Run a web app | ||
|
|
||
| Enter the following command to run a console app in a container with a pre-built [.NET Docker image](https://hub.docker.com/_/microsoft-dotnet-samples/): | ||
| The following example runs an [ASP.NET Core container image](https://hub.docker.com/_/microsoft-dotnet-samples/): |
Member
There was a problem hiding this comment.
Suggested change
| The following example runs an [ASP.NET Core container image](https://hub.docker.com/_/microsoft-dotnet-samples/): | |
| The following example runs an [ASP.NET Core container](https://hub.docker.com/_/microsoft-dotnet-samples/): |
|
|
||
| ## Image Update Policy | ||
|
|
||
| * We update the supported .NET images within 12 hours of any updates to their base images (e.g. debian:buster-slim, windows/nanoserver:ltsc2022, buildpack-deps:bionic-scm, etc.). |
Member
There was a problem hiding this comment.
This was removed but we don't actually mention this 12 hour SLA anywhere else.
| @@ -9,38 +9,25 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
Any changes to this doc need to be made the corresponding template file(s) in eng/readme-templates. This entire file is generated from those templates.
| * [Contact Microsoft Support](https://support.microsoft.com/contactus/) | ||
|
|
||
| # License | ||
| ## License |
Member
There was a problem hiding this comment.
This needs to be reverted. This header needs to be top-level to conform to the MAR Portal spec for readmes.
Suggested change
| ## License | |
| # License |
|
|
||
| ## Annotated Dockerfile -- Advanced platform targeting | ||
|
|
||
| The following [Dockerfile](aspnetapp/Dockerfile.alpine) offers more control for targeting, with the `--platform` switch. It is very similar to the prior sample, with a couple variations to change the behavior. In particular, we want the .NET SDK to always run natively (best performance and avoids running in QEMU, which .NET doesn't support). |
Member
There was a problem hiding this comment.
Provide a link to build-for-a-platform.md?
Comment on lines
+153
to
+154
| # This launch pattern launches an executable (since this Dockerfile is Linux-specific). | ||
| ENTRYPOINT ["./aspnetapp"] |
Member
There was a problem hiding this comment.
I think we should continue to use the DLL. See #3392
Comment on lines
+177
to
+178
|
|
||
|
|
| # copy csproj and restore as distinct layers | ||
| COPY *.csproj . | ||
| RUN dotnet restore --use-current-runtime | ||
| RUN dotnet restore --use-current-runtime |
Member
There was a problem hiding this comment.
Suggested change
| RUN dotnet restore --use-current-runtime | |
| RUN dotnet restore --use-current-runtime |
| @@ -1,147 +0,0 @@ | |||
| # Selecting .NET tags | |||
Member
There was a problem hiding this comment.
Why was this doc removed? There's useful information in here, particularly in the "Targeting a specific operating system" section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.