Merged
Conversation
Contributor
Author
|
After building the required
|
wfurt
approved these changes
Feb 5, 2023
Member
wfurt
left a comment
There was a problem hiding this comment.
LGTM
I'm wondering if we should move to newer base image e.g. Ubuntu 20 or 22 but I think it is fine if we do it later.
Contributor
Author
It can be done at any point. I was going to wait a bit as 18.04 reaches end of "Hardware and maintenance updates", FreeBSD 12.3 reaches EOL (leaving only FreeBSD 12.4 in support), and FreeBSD 13.2 releases all happen in late March. |
mthalman
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a FreeBSD 13 x64 image alongside the existing FreeBSD 13 ARM64 and FreeBSD 12 x64 images.