Merged
Conversation
mthalman
approved these changes
May 16, 2025
Member
There was a problem hiding this comment.
A couple follow-ups on this:
- It'd be good to have an issue logged on the scancode repo.
- We should an issue logged in this repo to revert this change once the scancode issue is fixed, referencing that issue as well.
@Winniexu01 - Can you take care of these tasks?
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#5159
License scan test failed due to an outdated attribute mapping in the scancode toolkit. The attribute is_hidden has been renamed to hidden, but this change has not yet been included in the latest version of the scancode toolkit.