Skip to content

Update PNSE for .NET 6#6770

Merged
gewarren merged 1 commit intodotnet:mainfrom
gewarren:exceptions-may
May 27, 2021
Merged

Update PNSE for .NET 6#6770
gewarren merged 1 commit intodotnet:mainfrom
gewarren:exceptions-may

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented May 26, 2021

Fixes #6666, fixes #1683.

  • Add missing exceptions.
  • Standardize wording.
  • Update link text for an article.

@gewarren gewarren requested a review from buyaa-n May 26, 2021 21:13
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label May 26, 2021
@AaronRobinsonMSFT
Copy link
Member

AaronRobinsonMSFT commented May 26, 2021

System.Runtime.InteropServices and MarshalByObject LGTM.

@opbld33
Copy link

opbld33 commented May 26, 2021

Docs Build status updates of commit bbc04c5:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.Common/DbDataReader.xml ✅Succeeded View
xml/System.Diagnostics/Process.xml ✅Succeeded View
xml/System.IO.MemoryMappedFiles/MemoryMappedFile.xml ✅Succeeded View
xml/System.IO/FileSystemInfo.xml ✅Succeeded View
xml/System.Net/AuthenticationManager.xml ✅Succeeded View
xml/System.Net/WebRequest.xml ✅Succeeded View
xml/System.Reflection/Assembly.xml ✅Succeeded View
xml/System.Reflection/AssemblyName.xml ✅Succeeded View
xml/System.Reflection/StrongNameKeyPair.xml ✅Succeeded View
xml/System.Runtime.CompilerServices/DebugInfoGenerator.xml ✅Succeeded View
xml/System.Runtime.InteropServices/RuntimeEnvironment.xml ✅Succeeded View
xml/System.Runtime.Serialization.Formatters.Binary/BinaryFormatter.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/CmsSigner.xml ✅Succeeded View
xml/System.Security.Cryptography.Pkcs/SignedCms.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/X509Certificate.xml ✅Succeeded View
xml/System.Security.Cryptography.X509Certificates/X509Certificate2.xml ✅Succeeded View
xml/System.Security.Cryptography/ProtectedData.xml ✅Succeeded View
xml/System.Security.Cryptography/RSA.xml ✅Succeeded View
xml/System.Text.RegularExpressions/Regex.xml ✅Succeeded View
xml/System.Text/Encoding.xml ✅Succeeded View
xml/System.Threading/Thread.xml ✅Succeeded View
xml/System/MarshalByRefObject.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View
xml/System/Uri.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@bartonjs
Copy link
Member

bartonjs commented May 26, 2021

System.Security.* LGTM

buyaa-n
buyaa-n approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! System.Reflection related changes LGTM

@buyaa-n buyaa-n requested a review from jeffhandley May 27, 2021 01:06
@kouvel
Copy link
Contributor

kouvel commented May 27, 2021

System.Threading changes LGTM

adamsitnik
adamsitnik approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.IO and System.Diagnostics.Process LGTM, thank you @gewarren

BillWagner
BillWagner approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 6a002e3 into dotnet:main May 27, 2021
@gewarren gewarren deleted the exceptions-may branch May 27, 2021 16:21
@gewarren
Copy link
Contributor Author

gewarren commented May 27, 2021

Thank you all for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@adamsitnik adamsitnik adamsitnik approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT AaronRobinsonMSFT is a code owner

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

@bartonjs bartonjs Awaiting requested review from bartonjs

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@cheenamalhotra cheenamalhotra Awaiting requested review from cheenamalhotra

@David-Engel David-Engel Awaiting requested review from David-Engel

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

@HongGit HongGit Awaiting requested review from HongGit

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky jkoritzinsky is a code owner

@joperezr joperezr Awaiting requested review from joperezr

@jozkee jozkee Awaiting requested review from jozkee

@kouvel kouvel Awaiting requested review from kouvel

@krwq krwq Awaiting requested review from krwq

@layomia layomia Awaiting requested review from layomia

@pgovind pgovind Awaiting requested review from pgovind

@StephenMolloy StephenMolloy Awaiting requested review from StephenMolloy StephenMolloy is a code owner

@steveharter steveharter Awaiting requested review from steveharter

@tannergooding tannergooding Awaiting requested review from tannergooding

@jeffhandley jeffhandley Awaiting requested review from jeffhandley

+1 more reviewer

@buyaa-n buyaa-n buyaa-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new PNSEs for .NET 6 Add PlatformNotSupported exception for APIs/platforms not supported in .NET Core

8 participants

@gewarren @AaronRobinsonMSFT @opbld33 @bartonjs @kouvel @BillWagner @adamsitnik @buyaa-n