Add documentation for WPF's System.Windows.Media.PenDashCap enum and System.Windows.Media.IAnimation interface#3018
Merged
rpetrusha merged 5 commits intodotnet:masterfrom Aug 19, 2019
Merged
Conversation
…System.Windows.Media.IAnimation interface
added 2 commits
August 15, 2019 15:51
ryalanms
commented
Aug 15, 2019
| </Base> | ||
| <Docs> | ||
| <summary>Describes the shape at the ends of each dash segment.</summary> | ||
| <summary>Describes the shape at the end of each dash segment.</summary> |
Member
Author
There was a problem hiding this comment.
Minor nitpick here: both ends of each dash are affected by the cap setting.
Contributor
There was a problem hiding this comment.
Which cap setting are you referring to? Should this information be included as a remark somewhere within this file?
Member
Author
There was a problem hiding this comment.
PenDashCap (this enum) is the shape (the line cap) at the ends of each dash segment. If that doesn't seem clear, 'line cap' can be added to the main description:
<summary>Describes the shape (the line cap) at the ends of each dash segment.</summary>
carlossanlop
approved these changes
Aug 15, 2019
Contributor
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM, approving. I left 3 small suggestions (spacing).
ryalanms
commented
Aug 15, 2019
Contributor
|
There are some warnings on the PR. I'll have to check later from home. I have a hard stop now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/wpf#1172. Note that there are no new WPF APIs for .NET Core.