Improve Volatile class documentation#2503
Merged
BillWagner merged 2 commits intodotnet:masterfrom May 28, 2019
MSDN-WhiteKnight:patch-1
Merged
Improve Volatile class documentation#2503BillWagner merged 2 commits intodotnet:masterfrom MSDN-WhiteKnight:patch-1
BillWagner merged 2 commits intodotnet:masterfrom
MSDN-WhiteKnight:patch-1
Conversation
Member
|
@kouvel Can you review this change? It looks correct to me, but I'd like your review as well. |
Contributor
|
Looks accurate to me as well, thanks! |
BillWagner
approved these changes
May 28, 2019
Member
BillWagner
left a comment
There was a problem hiding this comment.
Thanks for making this update @MSDN-WhiteKnight
We've reviewed this, and I'll 
now.
Thanks again for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace incorrect statement about
volatilekeyword in remarks.volatilekeyword does not techinically use Volatile.Read / Volatile.Write methods, but only causes all field access instructions to be volatile operations (which is effectively the same, but without a method call).Add See also link to the
volatilekeyword documentation.Related to https://github.com/dotnet/dotnet-api-docs.ru-ru/issues/22