[main] Source code updates from dotnet/roslyn#667
Merged
ViktorHofer merged 4 commits intomainfrom May 22, 2025
Merged
Conversation
Diff: https://github.com/dotnet/roslyn/compare/4b825dc642cb6eb9a060e54bf8d69288fbee4904..af9148202d31a6acbb16b55793d47420640eb9c4 From: dotnet/roslyn@4b825dc To: dotnet/roslyn@af91482 [[ commit created by automation ]]
Contributor
Author
Notification for subscribed users from https://github.com/dotnet/roslyn:@dotnet/roslyn-infrastructure Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
akoeplinger
reviewed
May 21, 2025
ViktorHofer
requested changes
May 21, 2025
Member
There was a problem hiding this comment.
As others mentioned, we can't make changes to Versions.props and Version.Details.xml directly in the VMR unless we then in the backflow PRs manually apply those changes again. They are currently dropped.
Tracking issue: dotnet/arcade-services#4840
@mthalman please fix this by submitting a PR into roslyn and the other repos with the Versions.props & Version.Details changes that you made in 21afdab#diff-1204c2fdb36b1ac7cbf4a1bb7357e38ee48587bd5f960d37da036bce652e98ee
Member
|
I have a roslyn PR here: dotnet/roslyn#78668 |
Diff: https://github.com/dotnet/roslyn/compare/af9148202d31a6acbb16b55793d47420640eb9c4..2b6024ed15fa4c003a9de9f486bdb84a44ef3d33 From: dotnet/roslyn@af91482 To: dotnet/roslyn@2b6024e [[ commit created by automation ]]
ViktorHofer
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/roslyn