Add retries to VerifySourcelinks test and log exit code and elapsed time#5479
Merged
akoeplinger merged 2 commits intomainfrom Mar 16, 2026
Merged
Add retries to VerifySourcelinks test and log exit code and elapsed time#5479akoeplinger merged 2 commits intomainfrom
akoeplinger merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flakiness in VerifySourcelinks by retrying failed sourcelink validations and improving failure diagnostics (exit code and elapsed time), aligning with dotnet/dotnet #5259.
Changes:
- Add per-PDB retries in
ValidateSymbolsto reduce intermittent sourcelink verification failures. - Extend failure reporting to include the sourcelink tool exit code and per-file elapsed time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
steveisok
approved these changes
Mar 15, 2026
Use ?. operator for Process access with -1 default exit code, and ?? operator for StdOut/StdErr to fix CS8602 and CS8620. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
steveisok
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #5259