Skip to content

[main] Source code updates from dotnet/fsharp#5225

Merged
dotnet-maestro[bot] merged 4 commits intomainfrom
darc-main-ea06075b-835a-4e48-89f3-4429f37c6d6e
Mar 6, 2026
Merged

[main] Source code updates from dotnet/fsharp#5225
dotnet-maestro[bot] merged 4 commits intomainfrom
darc-main-ea06075b-835a-4e48-89f3-4429f37c6d6e

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 4, 2026

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/fsharp

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/fsharp:64796117bf609b752495a9cd005695e7f3aba5ed..https://github.com/dotnet/dotnet:darc-main-ea06075b-835a-4e48-89f3-4429f37c6d6e

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 4, 2026

@dotnet-policy-service dotnet-policy-service bot requested a review from a team March 4, 2026 15:44
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 5, 2026

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

…ce-build

The fsharp PR dotnet/fsharp#19021 moved System.Collections.Immutable,
System.Composition, System.Diagnostics.DiagnosticSource, and
System.Reflection.Metadata from Version.Details.xml to hardcoded
properties in Versions.props. This causes prebuilt failures in
source-build because these packages are no longer tracked as
dependencies from dotnet/runtime.

Move them back to Version.Details.xml (with empty Sha, matching the
pattern used by dotnet/msbuild) and auto-generated Version.Details.props,
removing the hardcoded SystemPackagesVersion from Versions.props.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@akoeplinger
Copy link
Member

The source-manifest.json has edits for more than just the fsharp repo: dotnet/arcade-services#5943

@T-Gro We shouldn't merge this and open a new PR

@T-Gro
Copy link
Member

T-Gro commented Mar 6, 2026

@akoeplinger :
Did it self correct? Right now I only see a change for dotnet/fsharp in there...

@akoeplinger
Copy link
Member

hmm yeah. not sure how that's possible since there was no new commit, maybe the github diff was broken somehow?

@dotnet-maestro dotnet-maestro bot merged commit 0697b32 into main Mar 6, 2026
16 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-ea06075b-835a-4e48-89f3-4429f37c6d6e branch March 6, 2026 18:18
@dotnet-policy-service dotnet-policy-service bot requested a review from a team March 6, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants