Fix cloaking patterns for SBRP repo#4914
Merged
NikolaMilosavljevic merged 3 commits intodotnet:mainfrom Feb 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes cloaking patterns for the source-build-reference-packages (SBRP) repository to properly exclude files that should not be synchronized to the VMR. The changes address issue #5480 by correcting the pattern for spectre-console documentation files and making the PFX file exclusion more general.
Changes:
- Updated the spectre-console docs exclusion pattern to correctly match the actual file path structure
- Changed PFX exclusion from a specific path pattern to a global wildcard pattern to catch all PFX files
- Removed files that should have been excluded but were already present in the repo
Reviewed changes
Copilot reviewed 211 out of 254 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/source-mappings.json | Updated cloaking patterns: fixed spectre-console docs path and generalized PFX exclusion to **/*.pfx |
| src/source-build-reference-packages/src/externalPackages/src/spectre-console/docs/** | Deleted documentation files now properly excluded by the corrected pattern |
| Multiple *.pfx files | Deleted PFX certificate files now properly excluded by the generalized pattern |
Files not reviewed (1)
- src/source-build-reference-packages/src/externalPackages/src/spectre-console/docs/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ellahathaway
approved these changes
Feb 17, 2026
jonathanpeppers
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#5480
This PR also fixes the pattern for
spectre.consolefiles.Removing the files as cloaking does not remove the files already present in the repo.
Pattern for PFX file exclusion was suggested in dotnet/arcade-services#5949 (comment)