Cloak and condition the obfuscated test binaries#4603
Cloak and condition the obfuscated test binaries#4603NikolaMilosavljevic merged 1 commit intodotnet:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Roslyn test resources to avoid including obfuscated test binaries in VMR source tarball/signing scenarios.
Changes:
- Adds an
excludepattern for Roslyn obfuscated test DLLs insource-mappings.json - Conditions the
Obfuscated/Obfuscated2resource APIs out ofTestResourceswhen building from VMR - Conditions embedding of the obfuscated DLL resources (and defines a build symbol) in the resources
.csproj
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/source-mappings.json | Excludes obfuscated Roslyn test binaries from source mapping to unblock tarball signing |
| src/roslyn/src/Compilers/Test/Resources/Core/TestResources.cs | Conditionally removes accessors for obfuscated test resources in VMR builds |
| src/roslyn/src/Compilers/Test/Resources/Core/Microsoft.CodeAnalysis.Compiler.Test.Resources.csproj | Defines DOTNET_BUILD_FROM_VMR and conditionally embeds obfuscated resources |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/backport to release/10.0.1xx |
|
/backport to release/10.0.2xx |
|
/backport to release/11.0.1xx-preview1 |
|
@NikolaMilosavljevic this was due to the GitHub Actions / Azure outage yesterday, the action run didn't get a machine: https://github.com/dotnet/dotnet/actions/runs/21605659435?pr=4603+%28comment%29 it should work again now |
|
/backport to release/11.0.1xx-preview1 |
|
Started backporting to |
|
/backport to release/10.0.1xx |
|
Started backporting to |
Obfuscated files will block the source tarball signing.