Re-Bootstrap to .NET 11.0.100-preview.1.26078.107#4515
Closed
dotnet-bot wants to merge 3 commits intomainfrom
Closed
Re-Bootstrap to .NET 11.0.100-preview.1.26078.107#4515dotnet-bot wants to merge 3 commits intomainfrom
dotnet-bot wants to merge 3 commits intomainfrom
Conversation
ViktorHofer
reviewed
Jan 29, 2026
| @@ -1,4 +1,4 @@ | |||
| <Project> | |||
| <Project> | |||
Member
There was a problem hiding this comment.
@ellahathaway looks like the re-bootstrapping pipeline is updating the Versions.props file as UTF-8 with a BOM character. Should be without BOM.
Member
|
@ellahathaway do we need to update the "Validate user changes in VMR Run Validation Script" job to allow changes from "dotnet-bot"? |
ViktorHofer
reviewed
Jan 29, 2026
Member
There was a problem hiding this comment.
@jkoritzinsky I think we need to do some follow-up work here. We could provide an extension point somewhere here to have all the information available before RuntimeIdentifiers gets set.
ViktorHofer
reviewed
Jan 29, 2026
| If we infer a RID for the project, default to filtering down the list of RIDs the project specifies and automatically excluding projects that don't build for this RID. | ||
| --> | ||
| <_EnableArcadeRuntimeIdentifierFilters Condition="'$(_EnableArcadeRuntimeIdentifierFilters)' == '' and '$(_EnableArcadeRuntimeIdentifierInference)' == 'true'">$(_EnableArcadeRuntimeIdentifierFilters)</_EnableArcadeRuntimeIdentifierFilters> | ||
| <_EnableArcadeRuntimeIdentifierFilters Condition="'$(_EnableArcadeRuntimeIdentifierFilters)' == '' and '$(_EnableArcadeRuntimeIdentifierInference)' == 'true'">true</_EnableArcadeRuntimeIdentifierFilters> |
Member
There was a problem hiding this comment.
@jkoritzinsky I noticed that this was always a no-op and so the PropertyGroup below in L75 (new diff) never ran.
Member
|
Continuing in the new re-bootstrap PR: #4521 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-Bootstrap .NET to 11.0.0-preview.1.26078.107 / 11.0.100-preview.1.26078.107.