Revert "Revert temporary ITypeSymbol extension APIs"#4404
Merged
ViktorHofer merged 1 commit intomainfrom Jan 26, 2026
Merged
Conversation
This reverts commit beef13c.
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the temporary ITypeSymbol “extension type” APIs that were previously reverted (per #2822), while directing consumers to prefer the INamedTypeSymbol equivalents.
Changes:
- Re-adds
ITypeSymbol.IsExtensionandITypeSymbol.ExtensionParameteras[Obsolete]members. - Updates implementations in C# PublicModel, VB
TypeSymbol, and workspace codegen symbols (with version-guarding where needed). - Updates shipped/public API baselines and semantic search reference API lists.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/roslyn/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/Core/CodeGeneration/Symbols/CodeGenerationTypeSymbol.cs | Adds conditional explicit ITypeSymbol implementations for the restored members for newer Roslyn builds. |
| src/roslyn/src/Tools/SemanticSearch/ReferenceAssemblies/Apis/Microsoft.CodeAnalysis.txt | Updates the semantic-search reference API list to include the restored ITypeSymbol getters. |
| src/roslyn/src/Compilers/VisualBasic/Portable/Symbols/TypeSymbol.vb | Implements the restored ITypeSymbol members on VB’s TypeSymbol. |
| src/roslyn/src/Compilers/Core/Portable/Symbols/ITypeSymbol.cs | Restores the temporary APIs on ITypeSymbol and marks them obsolete with guidance to use INamedTypeSymbol. |
| src/roslyn/src/Compilers/Core/Portable/Symbols/INamedTypeSymbol.cs | Adds new to INamedTypeSymbol members to resolve the newly introduced name collision from the base interface. |
| src/roslyn/src/Compilers/Core/Portable/PublicAPI.Shipped.txt | Updates shipped API baseline to include the restored ITypeSymbol members. |
| src/roslyn/src/Compilers/CSharp/Portable/Symbols/PublicModel/TypeSymbol.cs | Implements the restored ITypeSymbol members for C# public symbols. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jjonescz
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2822
To avoid breaking net10.0 projects, we'll need to ship dotnet/runtime#123509 before making this breaking change. @jjonescz @agocke