Fix OmniSharp tests silently passing on script execution failures#3954
Merged
Fix OmniSharp tests silently passing on script execution failures#3954
Conversation
Adds checks for "command not found" and "No such file or directory" in stderr to prevent tests from silently passing when the OmniSharp run script fails to execute properly. Co-authored-by: mthalman <15789599+mthalman@users.noreply.github.com>
Applied code review feedback to make error message detection more robust by using case-insensitive comparison. Co-authored-by: mthalman <15789599+mthalman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix silent failure in OmniSharp tests execution
Fix OmniSharp tests silently passing on script execution failures
Dec 18, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes OmniSharp tests that were silently passing when script execution failed with errors like "mono: command not found". The test was designed to expect a non-zero exit code from killing the OmniSharp process after a timeout, but script execution failures also produce non-zero exit codes, leading to false positives.
Changes:
- Changed OmniSharp execution from shell script to direct .NET execution via
dotnet OmniSharp.dll - Added assertions to detect shell execution failures in stderr (case-insensitive checks for "command not found" and "No such file or directory")
- Updated OmniSharp tarball download to use the net6.0 variant instead of the mono-based version
- Added omnisharp.json configuration file to enable prerelease .NET SDK support
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ellahathaway
approved these changes
Jan 13, 2026
Member
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to |
Member
|
/backport to release/10.0.2xx |
Contributor
|
Started backporting to |
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OmniSharp tests were passing when the run script failed with "mono: command not found". The test expects non-zero exit from killing the process after timeout, but script failures also produce non-zero exit codes, causing false positives.
Changes
"command not found"- catches missing executables (mono, bash, etc.)"No such file or directory"- catches missing files/scriptsContext
This issue is specific to main branch due to ExecuteHelper.cs being imported from dotnet/sdk in commit 94383bd. The release/10.0.1xx branch uses a different process execution implementation.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.