[main] Fixup template versions and windowsdesktop stack versions#3341
Merged
ViktorHofer merged 3 commits intodotnet:mainfrom Nov 17, 2025
Merged
[main] Fixup template versions and windowsdesktop stack versions#3341ViktorHofer merged 3 commits intodotnet:mainfrom
ViktorHofer merged 3 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates template package version references and WindowsDesktop stack version handling to use proper dependency tracking instead of VMR-specific workarounds. The changes align version management with the standard Arcade/Maestro dependency flow system.
Key Changes
- Replaced shared
MicrosoftNETSdkWindowsDesktopPackageVersionreference with specific package version properties for WinForms and WPF project templates - Added explicit dependency entries for
Microsoft.Dotnet.WinForms.ProjectTemplatesandMicrosoft.Dotnet.Wpf.ProjectTemplatesin Version.Details.xml - Removed VMR-specific version aliasing and comments that are no longer necessary
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/sdk/src/Layout/redist/targets/BundledTemplates.targets | Updated to reference specific package version properties for WinForms and WPF templates instead of shared WindowsDesktop SDK version |
| src/sdk/eng/Version.Details.xml | Added dependency entries for WinForms and WPF project templates; removed obsolete VMR-related comment |
| src/sdk/Directory.Build.props | Removed VMR-specific version aliasing; WindowsDesktop package versions now sourced from proper dependency tracking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ViktorHofer
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port from #3290