Use stable sdk verison in inner artifact directory#3254
Merged
ellahathaway merged 2 commits intodotnet:mainfrom Nov 10, 2025
Merged
Use stable sdk verison in inner artifact directory#3254ellahathaway merged 2 commits intodotnet:mainfrom
ellahathaway merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the source artifact creation process to separate SDK version concerns into two distinct properties: a stable SDK version for artifact prefixes and a non-stable version for artifact file naming.
- Renamed
ArtifactVersionparameter to split it intoSdkVersion(for git archive prefixing) andSdkNonStableVersion(for artifact file naming) - Updated the
GetGitArchiveArgsmethod parameter fromartifactVersiontoartifactPrefixVersionfor clarity - Modified the MSBuild task invocation to pass both version properties separately
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Models/ArtifactType.cs | Renamed method parameter to artifactPrefixVersion to better reflect its usage in the git archive prefix |
| eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/CreateSourceArtifacts.cs | Split ArtifactVersion property into SdkVersion and SdkNonStableVersion with updated documentation |
| eng/finish-source-only.proj | Updated CreateSourceArtifacts task to pass both SdkVersion and SdkNonStableVersion properties |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/CreateSourceArtifacts.cs
Show resolved
Hide resolved
eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/CreateSourceArtifacts.cs
Outdated
Show resolved
Hide resolved
mthalman
approved these changes
Nov 6, 2025
eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/CreateSourceArtifacts.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
I verified that these changes produce the same GA source artifacts as the GitHub generated source artifacts in maestro-auth-test. |
mthalman
approved these changes
Nov 10, 2025
Member
Author
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to |
Member
|
/backport to release/10.0.2xx |
Contributor
|
Started backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/release/issues/1709
The GitHub source artifacts associated with an SDK release use the stable SDK version in the inner directory of the source artifacts. In other words, the inner directory of the artifacts includes the SDK version tag without the
vtag prefix.The source artifacts generated in our builds must have the same inner directory name as the GitHub source artifacts. Otherwise, the hashes of the artifacts do not match and the signatures are invalid.