Update api-diff tests#2829
Merged
NikolaMilosavljevic merged 1 commit intodotnet:mainfrom Oct 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates API diff tests by removing two suppressions from the baseline file that are no longer needed due to a recent fix, and ensures that updated API diff baselines are properly published in the build pipeline.
- Removed two API diff suppressions for System.ComponentModel.Composition.dll components
- Added collection of .suppression files to the build artifacts staging process
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Microsoft.DotNet.SourceBuild.Tests/assets/SdkContentTests/ApiDiff.suppression | Removes two CP0002 and CP0008 suppressions for System.ComponentModel.Composition.dll |
| eng/pipelines/templates/jobs/sdk-diff-tests.yml | Adds .suppression files to the artifacts collection process |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mthalman
approved these changes
Oct 10, 2025
MichaelSimons
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing tests
Removing two differences from the baseline to account for a recent fix.
Also updating the file collection step to ensure that updated api-diff baseline gets published.