I assume the TODO should be an issue that includes:

• releasing MSBuildLocator (1.8.2?) that includes the patch
• have it used by all dotnet repos
• let externalPackages use that version and remove the patch

Should that issue be created in the msbuild repo?

Yes, exactly that. The issue can live in the VMR as the update will probably also be done here as it touches multiple repos.

@YuliiaKovalova is currently fighting the Locator official build, which seems to have developed some problems since it last ran (naturally 🙃).

@ViktorHofer I've created #2716 and referenced it in the top-level comment of this PR. Do I need to update the commit message as well, or is this good to merge?

@rainersigwald assuming this is ask-mode can someone on your side please handle the request?

@tmds the package with the fix has been released: dotnet add package Microsoft.Build.Locator --version 1.10.2

assuming this is ask-mode can someone on your side please handle the request?

@YuliiaKovalova @rainersigwald are you looking into this?

@tmds given that the package is already released do you want to handle the update? (in this PR ideally)

For awareness: 1.10.2 includes some additional changes that have only been recently made to MSBuildLocator: https://github.com/microsoft/MSBuildLocator/commits/v1.10.2/.

I'll update the PR to use it.

in this PR ideally

I'm not sure what to do.

MSBuildLocator in a submodule in https://github.com/dotnet/source-build-reference-packages/tree/main/src/externalPackages/src and in this repo it exist as source files.

@ViktorHofer if the intent is to change the MSBuildLocator for .NET 10.0.0 to the v1.10.2, then I think it's simplest if we close this PR and let @YuliiaKovalova and @rainersigwald handle that.

The submodule needs to be updated in https://github.com/dotnet/source-build-reference-packages and the change then flows into the VMR automatically. In that SBRP -> VMR PR we can then update the rest of the stack. Just sharing for whoever wants to make the update.

assuming this is ask-mode can someone on your side please handle the request?

This question is still open.

Just sharing for whoever wants to make the update.

Let me know if it is helpful for me to do this. I don't want to be in the way.

Let me know if it is helpful for me to do this. I don't want to be in the way.

I don't think anyone is assigned to this work, yet. If you want to help, that would be appreciated :)

I've updated this PR to set the version to v1.10.2 in various dotnet repos (as used by the Microsoft build).
dotnet/source-build-reference-packages#1399 is for updating the version used by source-build.

This PR is currently targeting release/10.0.1xx. The source-build-reference-packages PR is targeting release/10.0.

Part of #2802.