Skip to content

[main] Source code updates from dotnet/sdk #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dotnet-maestro merged 8 commits into from
Oct 3, 2025
Merged

[main] Source code updates from dotnet/sdk #2674

dotnet-maestro merged 8 commits into from
Oct 3, 2025

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 30, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/sdk

@akoeplinger
Copy link
Member

akoeplinger commented Oct 3, 2025 

.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(120,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) The "ProcessFrameworkReferences" task failed unexpectedly.
System.FormatException: Input string was not in a correct format. Failure to parse near offset 47. Expected an ASCII digit.
   at System.Text.ValueStringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
   at System.String.FormatHelper(IFormatProvider provider, String format, ReadOnlySpan`1 args)
   at Microsoft.NET.Build.Tasks.Logger.CreateMessage(MessageLevel level, String format, String[] args) in /_/src/sdk/src/Tasks/Common/Logger.cs:line 94
   at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.AddPacksForFrameworkReferences(List`1 packagesToDownload, List`1 runtimeFrameworks, List`1 targetingPacks, List`1 runtimePacks, List`1 unavailableRuntimePacks, List`1& knownRuntimePacksForTargetFramework) in /_/src/sdk/src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs:line 241
   at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.ExecuteCore() in /_/src/sdk/src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs:line 436
   at Microsoft.NET.Build.Tasks.TaskBase.Execute() in /_/src/sdk/src/Tasks/Common/TaskBase.cs:line 36
   at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() in /_/src/msbuild/src/Build/BackEnd/TaskExecutionHost/TaskExecutionHost.cs:line 617
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) in /_/src/msbuild/src/Build/BackEnd/Components/RequestBuilder/TaskBuilder.cs:line 816

@baronfel

@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

@akoeplinger pushed a change that should at least tell me the failing format string so that can be investigated further.

@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

Ah, it's the same thing I fixed in another codeflow - I guess RC2 and/or 10 GA haven't merged down to main yet?

@baronfel baronfel force-pushed the darc-main-f2c9ae08-506c-4b99-bd24-606e2af28182 branch from e14ded8 to 6f9748c Compare October 3, 2025 16:10
@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

Should be good to go now - there was a latent type in a MSBuild Item metadata update.

@akoeplinger
Copy link
Member

akoeplinger commented Oct 3, 2025

ohh that one, I remember it. from what I can see it is in dotnet/sdk 10.0.1xx but not in main, even though there have been 10.0->main merges in the meantime...

@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

@akoeplinger yeah - that slightly concerns me too.

@dotnet-maestro dotnet-maestro bot merged commit 7b673bb into main Oct 3, 2025
16 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-f2c9ae08-506c-4b99-bd24-606e2af28182 branch October 3, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baronfel baronfel baronfel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

.NET Unified Build
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akoeplinger @baronfel