Skip to content

[main] Source code updates from dotnet/aspnetcore#2211

Merged
dotnet-maestro[bot] merged 13 commits intomainfrom
darc-main-96c03e8b-7eba-4f8e-ae2a-10abee6f0df4
Sep 10, 2025
Merged

[main] Source code updates from dotnet/aspnetcore#2211
dotnet-maestro[bot] merged 13 commits intomainfrom
darc-main-96c03e8b-7eba-4f8e-ae2a-10abee6f0df4

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 30, 2025

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/aspnetcore

@dkurepa
Copy link
Copy Markdown
Member

dkurepa commented Sep 1, 2025

@wtgodbe it looks like the

  • MicrosoftCodeAnalysisCommonVersion
  • MicrosoftCodeAnalysisCSharpVersion
  • MicrosoftCodeAnalysisCSharpWorkspacesVersion
  • MicrosoftCodeAnalysisExternalAccessAspNetCoreVersion
  • MicrosoftBuildVersion
  • MicrosoftBuildFrameworkVersion
  • MicrosoftBuildTasksCoreVersion
  • MicrosoftBuildUtilitiesCoreVersion

props really are duplicates in Versions.props and Versions.Details.props.
There are a few ways to resolve this:

  • These props are in excluded assets for the subscription, meaning they'll never get updated by Maestro. If you want, you can remove them in Versions.props and they won't change (you just won't have the comment)
  • The other option is to add the SkipProperty attribute to Version.Details.xml properties. This will make them not appear in Version.Details.props, and and thus they'll be ignored by the check
  • I think removing them from Version.Details.xml probably won't work because of source build, so that's not an option

@dotnet-maestro dotnet-maestro bot merged commit c20b9fb into main Sep 10, 2025
16 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-96c03e8b-7eba-4f8e-ae2a-10abee6f0df4 branch September 10, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants