@wtgodbe looks like the runtime aspnetcore transport package change now needs a reaction here for aspnetcore

@am11 @steveisok the cdac packages fail to AOT in the source-build job, Restore-Build.proj.binlog shows this:

I restored the condition which disabled it for source-only build to unblock this PR (a couple people are waiting for this to go in)

https://github.com/dotnet/runtime/blob/52d934e60227c12e7d58b5824bde9a480141c915/src/native/managed/subproject.props#L7 should be <SubprojectProps Include="RuntimeIdentifier" Value="$(PortableOS)-$(TargetArchitecture)" /> to support non-portable RID (same thing used in related ilcompiler_published and crossgen2_published projects).

ok, new issue :)

src/runtime/artifacts/.packages/microsoft.dotnet.build.tasks.packaging/10.0.0-ci/build/Packaging.targets(1274,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Error when creating nuget lib package from /__w/1/s/src/runtime/artifacts/packages/Release/specs/runtime.centos.10-x64.Microsoft.DotNet.Cdac.Transport.nuspec. System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/src/runtime/artifacts/bin/mscordaccore_universal/Release/net10.0/centos.10-x64/publish'.
   at System.IO.Enumeration.FileSystemEnumerator`1.Init()
   at System.IO.Enumeration.FileSystemEnumerableFactory.UserFiles(String directory, String expression, EnumerationOptions options)
   at NuGet.Common.PathResolver.PerformWildcardSearch(String basePath, String searchPath, Boolean includeEmptyDirectories, String& normalizedBasePath)
   at NuGet.Packaging.PackageBuilder.AddFiles(String basePath, String source, String destination, String exclude)
   at NuGet.Packaging.PackageBuilder.PopulateFiles(String basePath, IEnumerable`1 files)
   at Microsoft.DotNet.Build.Tasks.Packaging.NuGetPack.Pack(String nuspecPath, String nupkgPath, Manifest manifest, Boolean packSymbols) in /_/src/arcade/src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetPack.cs:line 261

Should we use $(PortableTargetRid) instead? That is set to $(PortableOS)-$(TargetArchitecture) in eng/RuntimeIdentifier.props

Should we use $(PortableTargetRid) instead? That is set to $(PortableOS)-$(TargetArchitecture) in eng/RuntimeIdentifier.props

Fine by me.

I see that centos is still failing. I'd just skip packaging cdac for source build and we can fix this later.

Ok now it fails with

src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj(0,0): error NU1100: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to resolve 'Microsoft.NETCore.App.Runtime.linux-x64 (= 10.0.0-ci)' for 'net10.0'. PackageSourceMapping is enabled, the following source(s) were not considered: /__w/1/s/.dotnet/library-packs, prebuilt, previously-source-built, reference-packages, source-built-command-line-api, source-built-source-build-reference-packages, source-built-transport-arcade, source-built-transport-cecil.

@steveisok I agree we should disable building cdac packages in the meantime, mind pushing to the PR?

It's a different leg? Earlier CentOSStream10_Online_MsftSdk_x64 was failing which is now green. Lets disable it for SB then (I tried 🤷‍♀️).

@jkoritzinsky, this is the case of P2P reference (StressLogAnalyzer.csproj -> Microsoft.Diagnostics.DataContractReader.Contracts.csproj) of such project where host with portable RID is unavailable during the non-portable build in offline-only SB leg. When you get some time, please take a look in light of dotnet/runtime#117436 (comment), so cDAC can be made available in source-build scenarios.

I think we will need to separate cDAC _inbuild and _published csprojs same as ilc / cg2 to satisfy the matrix.