Closed
Conversation
Member
Author
|
There are 261 violation in a total of 230 file. I'm not sure if you consider this number large or not. Let me know if you want to fix these or not. and in any case, if there are more articles to be moved from dotnet/docs, I don't think it's a good idea to enable the rule. |
Contributor
|
Good idea. How about we export the results into a new issue. This way we can break the fixes up into manageable (and reviewable) parts and let the community have opportunity to contribute to the work. |
Member
Author
|
@adegeo, Great. I've opened an issue to track that work. How much violations do you think is reasonable to be fixed per PR? |
Contributor
|
20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to see how big the violations of this rule.
The documentation of the rule mentions that violations affect accessibility scenarios. Given that this repo is much smaller than dotnet/docs, the violations could be manageable to fix. If they are too many, I'll close.