Add simplified null parameter checks#28890
Merged
BillWagner merged 10 commits intodotnet:mainfrom Apr 5, 2022
Merged
Conversation
IEvangelist
previously approved these changes
Apr 1, 2022
Member
IEvangelist
left a comment
There was a problem hiding this comment.
Looks awesome! Just have a few suggestions, otherwise 
Youssef1313
reviewed
Apr 1, 2022
gfoidl
reviewed
Apr 2, 2022
Youssef1313
reviewed
Apr 3, 2022
Create first draft for `!!` operator.
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> Co-authored-by: Günther Foidl <gue@korporal.at>
Youssef1313
reviewed
Apr 5, 2022
Youssef1313
reviewed
Apr 5, 2022
I've made significant edits since this was approved.
Youssef1313
reviewed
Apr 5, 2022
Comment on lines
+5
to
+6
| f1_keywords: | ||
| - "!!_CSharpKeyword" |
Member
There was a problem hiding this comment.
Oh, great. Do we need to wire anything up to make that happen?
Member
There was a problem hiding this comment.
@RikkiGibson Likely yes we'll need to update CSharpHelpContextService. Tests
IEvangelist
approved these changes
Apr 5, 2022
Member
|
@BillWagner thanks for the updates! Now it reads very well and correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28443
Add what's new information for the
!!operator, available in VS 17.1, and .NET SDK 6.0.200 as preview features.