Skip to content

XNodeReader.GetAttribute breaking change#26579

Merged
gewarren merged 2 commits intodotnet:mainfrom
gewarren:xnodereader
Oct 20, 2021
Merged

XNodeReader.GetAttribute breaking change#26579
gewarren merged 2 commits intodotnet:mainfrom
gewarren:xnodereader

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 19, 2021

Fixes #26551

Preview

@dotnet-bot dotnet-bot added this to the October 2021 milestone Oct 19, 2021
@gewarren gewarren requested review from a team and krwq October 19, 2021 23:54
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit d57a7e1 into dotnet:main Oct 20, 2021
@gewarren gewarren deleted the xnodereader branch October 20, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XNodeReader.GetAttribute(int) handling of invalid indices

3 participants