Add documentation about new ReadyToRun publish options#25780
Merged
davidwrighton merged 3 commits intodotnet:mainfrom Sep 1, 2021
Merged
Add documentation about new ReadyToRun publish options#25780davidwrighton merged 3 commits intodotnet:mainfrom
davidwrighton merged 3 commits intodotnet:mainfrom
Conversation
Member
davidwrighton
commented
Aug 24, 2021
- Composite R2R
- Symbol generation
- Exclusion from R2R
- Updated cross-targetting details
- Composite R2R - Symbol generation - Exclusion from R2R - Updated cross-targetting details
Member
Author
trylek
previously approved these changes
Aug 25, 2021
Member
trylek
left a comment
There was a problem hiding this comment.
LGTM, thanks for improving the documentation David! AFAIK you've covered the important bits, I'm not aware of any other user-facing SDK capabilities regarding Crossgen2. At some point it might be useful to document the E2E symbol-related scenarios but that's beyond the scope of your pending change.
…hat files are generated.
Member
Author
|
@trylek, could you review the additional change I made about the symbol generation? |
trylek
approved these changes
Sep 1, 2021
Member
trylek
left a comment
There was a problem hiding this comment.
The additional delta looks good to me too, thanks David!
trylek
approved these changes
Sep 1, 2021
Member
trylek
left a comment
There was a problem hiding this comment.
Thanks for adding the clarifying comment!
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.