Skip to content

Move the assembly property information to the msbuild info article#22918

Merged
gewarren merged 8 commits intomainfrom
adegeo-22858-moveassembly
Mar 26, 2021
Merged

Move the assembly property information to the msbuild info article#22918
gewarren merged 8 commits intomainfrom
adegeo-22858-moveassembly

Conversation

@adegeo
Copy link
Contributor

@adegeo adegeo commented Feb 19, 2021

Summary

This moves all of the content that was in assembly-info.md to the MSBuild article. There is a note in the linked issue to reference this content as part of the newer migration guide coming soon.

@gewarren I see that this file was recently created, however, I'm getting ready to start work on redoing all the migration content (with help from the product group) and I'm working on cleaning this stuff up. I think it makes more sense to have this information in the MSBuild props article and then referenced by migration articles.

Contributes to #22858

@adegeo adegeo requested a review from CamSoper February 19, 2021 21:54
@adegeo adegeo requested review from a team and gewarren as code owners February 19, 2021 21:54
@dotnet-bot dotnet-bot added this to the February 2021 milestone Feb 19, 2021
@adegeo adegeo requested review from tdykstra and removed request for a team, CamSoper and tdykstra February 19, 2021 21:54
@gewarren
Copy link
Contributor

@adegeo The content was intentionally split out (from the old csproj.md article) based on this request. So to move it back in contradicts the intent of that issue, which was to improve SEO/findability. Do you think linking from the migration guide will solve that problem?

@adegeo
Copy link
Contributor Author

adegeo commented Feb 22, 2021

@gewarren Ahhh gotcha. OK that makes sense why it was still here. However, I only saw 32 visitors in the last month, that can be considered such low traffic that the article isn't worth keeping around. I don't know if we're hitting our SEO targets for this article as it stands. Searching for various forms of assemblyinfo csproj file and assemblyinfo csproj error and duplicate assembly attribute csproj continually point me to StackOverflow Q/A and other articles. I couldn't surface this one.

Something else I noticed though too is that I think the MSBuild info article may be hurting overall SEO also since all of the H2s have no descriptions, only links under them. Anyway, with the low traffic, working on adding descriptions to the H2s in the MSBuild article, cross linking to it in further migration guides, we should really have all the bases covered.

Thoughts?

@gewarren
Copy link
Contributor

@gewarren Ahhh gotcha. OK that makes sense why it was still here. However, I only saw 32 visitors in the last month, that can be considered such low traffic that the article isn't worth keeping around. I don't know if we're hitting our SEO targets for this article as it stands. Searching for various forms of assemblyinfo csproj file and assemblyinfo csproj error and duplicate assembly attribute csproj continually point me to StackOverflow Q/A and other articles. I couldn't surface this one.

The article has only been live since January 8th 2021.

@adegeo
Copy link
Contributor Author

adegeo commented Feb 23, 2021

@gewarren

The article has only been live since January 8th 2021.

Ahh OK that makes sense then why results haven't surfaced. Do you think it would be better to move this to an include and have it in both? Full reference in this article and then the good-for-SEO article?

@gewarren
Copy link
Contributor

Do you think it would be better to move this to an include and have it in both? Full reference in this article and then the good-for-SEO article?

I don't think that's necessary. I wonder, though, if we should consider breaking up msbuild-props.md into separate articles for each section, for SEO.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@adegeo adegeo force-pushed the adegeo-22858-moveassembly branch from 065116f to f2b1197 Compare March 3, 2021 00:27
Base automatically changed from master to main March 5, 2021 23:33
@BillWagner BillWagner modified the milestones: February 2021, March 2021 Mar 11, 2021
Base automatically changed from main to master March 17, 2021 17:05
Base automatically changed from master to main March 17, 2021 17:06
@adegeo
Copy link
Contributor Author

adegeo commented Mar 26, 2021

@gewarren regarding SEO. H2s should be SEO scannable, but I think it helps SEO to have a paragraph description right below the H2. I think the lack of text below the H2 hurts these sections.

Still good to commit this? I just fixed a merge conflict. If you're happy with this change, let's merge it in.

@gewarren gewarren merged commit 757cf82 into main Mar 26, 2021
@gewarren gewarren deleted the adegeo-22858-moveassembly branch March 26, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants