Add using-statement F1 keyword#21209
Conversation
BillWagner
left a comment
There was a problem hiding this comment.
Thanks again @TheSench
I had one question that we should resolve before merging this.
Once that's figured out, we can complete the changes and merge this.
| ms.date: 04/05/2019 | ||
| f1_keywords: | ||
| - "using_CSharpKeyword" | ||
| - "using" |
There was a problem hiding this comment.
If this keyword won't be generated by Visual Studio F1, I'd like to remove this article. It has no content, and it's only purpose is to provide a single click to send readers where they want to get to.
We'd also need to check for links and remove links to this page.
@davidwengier do you know if "using" is generated from Visual Studio?
There was a problem hiding this comment.
Right now, Roslyn appends _CSharpKeyword for any language construct it is trying to access help for, so unless there is an old version of Visual Studio that might be triggering this (that we care about) so as far as the f1_keywords goes I don't expect this to be ever used.
There was a problem hiding this comment.
What about users browsing the documentation outside of F1-help? If they were to go to the keywords page, what should they see? I think leaving in the using page for that purpose makes sense. There's no "using-statement" keyword, they would expect a "using" keyword page.
There was a problem hiding this comment.
Ping @BillWagner in case you didn't see this comment.
I'm happy from the Roslyn side of this, and the PR on that side is ready to go when this is in, but this question is for the docs point of view.
There was a problem hiding this comment.
Sorry, missed this comment. Thanks for the ping.
This is good to go, and I'll 
now.
Summary
This PR adds an f1_keyword for the using-statement context of the
usingkeyword and moves the defaultusingkeyword to theusing-directivepage. This allows the F1 help to route this keyword to pages more specific to the context in which it is being used.Fixes part of #20799, Roslyn changes under dotnet/roslyn#48898.