Add F1 keywords for default token semantics#21034
Conversation
| - "case" | ||
| - "case_CSharpKeyword" | ||
| - "defaultcase_CSharpKeyword" | ||
| - "defaultcase" |
There was a problem hiding this comment.
This looks redundant. Only defaultcase_CSharpKeyword is needed based on your Roslyn PR.
There was a problem hiding this comment.
Add, I wasn't aware, I kept seeing foo and foo_CSharpKeyword, so I thought both were necessary. Thanks for letting me know.
| - "default_CSharpKeyword" | ||
| - "default" | ||
| - "defaultvalue_CSharpKeyword" | ||
| - "defaultvalue" |
| - "default_CSharpKeyword" | ||
| - "default" |
There was a problem hiding this comment.
We can delete this to avoid duplicate f1_keywords.
But don't delete it from keywords/default.md for backcompat with older Roslyn versions.
| - "default_CSharpKeyword" | |
| - "default" |
Also adding @davidwengier and @BillWagner for opinions.
There was a problem hiding this comment.
I think this is a good change.
There was a problem hiding this comment.
As mentioned in the Roslyn PR, it also means one less added keyword, since we can now just use the existing default_CSharpKeyword one that's already on the operator page.
|
@davidwengier based on the discussion in dotnet/roslyn#48500, I opted to reuse the existing Let me know if I should undo this change and I'll just rebase those commits out so that the overall history is less polluted. |
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @TheSench
I'll approve this, and 
now.
You should see the changes on the live site tomorrow, during our regular publishing cycle. After that, the roslyn PR can be tested against the live site.
Summary
This PR adds two separate f1_keywords for different semantics of the
defaultkeyword. This allows the F1 help to route to the appropriate page based on the context, rather than having to route to a genericdefaultpage.Fixes part of #20799, Roslyn changes under dotnet/roslyn#48392.